Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more input trait impls for open drain outputs #905

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Add more input trait impls for open drain outputs #905

merged 2 commits into from
Nov 8, 2023

Conversation

jneem
Copy link
Contributor

@jneem jneem commented Nov 6, 2023 •
edited
Loading

This adds embedded_hal_1::digital::InputPin and embedded_hal_async::Wait implementations for GpioPin<Output<OpenDrain>, _>. Previously, there was only an impl of embedded_hal::digital::v2::InputPin, so I'm assuming that the others were just left out unintentionally.

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

bjoernQ
bjoernQ approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JurajSadel
JurajSadel approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit aa1fefd into esp-rs:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JurajSadel JurajSadel JurajSadel approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jneem @bjoernQ @JurajSadel